[2.x] Fix lopsided post divider on mobile#4691
Merged
Merged
Conversation
The divider between posts is 20px short on the right to line up with .Post's right padding, but on phones that padding is removed, leaving the divider narrower than the post content. Make it full width at phone sizes. Fixes flarum#4690
karl-bullock
changed the title
imorland
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4690
Changes proposed in this pull request:
The divider between posts (
.PostStream-item::after) iscalc(100% - var(--post-padding))wide and left-aligned, which matches.Post's 20px right padding on desktop. On phones.Postdrops its right padding, so the post content goes full width while the divider stays 20px short on the right - at 390px wide that's a 15px gap on the left vs 35px on the right.This makes the divider full width inside the existing
@media @phoneblock, so it lines up with the post content again. Desktop is untouched.Reviewers should focus on:
Checked at 390px in Chrome device emulation against current 2.x-dev and the same rule in rc.1: gaps go from 15/35 to 15/15. Nothing else uses that
::after.Screenshot
Before/after measurements are in #4690, can add actual screenshots if wanted.