Skip to content

[tool] consistently use environment (not globals) in targets/web.dart#125937

Merged
auto-submit[bot] merged 7 commits into
masterfrom
web_build_context
May 4, 2023
Merged

[tool] consistently use environment (not globals) in targets/web.dart#125937
auto-submit[bot] merged 7 commits into
masterfrom
web_build_context

Conversation

@kevmoo

@kevmoo kevmoo commented May 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Also update the order of args to commands so that testing has less repeated "stuff"

@flutter-dashboard flutter-dashboard Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 3, 2023
@kevmoo kevmoo changed the base branch from master to kevmoo_tool_depfileservice May 3, 2023 03:33
kevmoo
kevmoo commented May 3, 2023
View reviewed changes
Comment thread packages/flutter_tools/lib/src/build_system/targets/web.dart
kevmoo
kevmoo commented May 3, 2023
View reviewed changes
Comment thread packages/flutter_tools/lib/src/build_system/targets/web.dart
Base automatically changed from kevmoo_tool_depfileservice to master May 3, 2023 20:54
@kevmoo kevmoo force-pushed the web_build_context branch from 361949f to 9fa2a24 Compare May 3, 2023 22:13
@kevmoo kevmoo marked this pull request as ready for review May 3, 2023 22:52
@kevmoo kevmoo changed the title web build context [tool] consistently use environment (not globals) in targets/web.dart May 3, 2023
@kevmoo kevmoo added the platform-web Web applications specifically label May 3, 2023
@kevmoo kevmoo requested a review from yjbanov May 4, 2023 00:30
eyebrowsoffire
eyebrowsoffire approved these changes May 4, 2023
View reviewed changes

@eyebrowsoffire eyebrowsoffire left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/flutter_tools/lib/src/build_system/targets/web.dart
@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label May 4, 2023
@auto-submit auto-submit Bot merged commit 5816da8 into master May 4, 2023
@auto-submit auto-submit Bot deleted the web_build_context branch May 4, 2023 00:47
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
5816da8 [tool] consistently use environment (not globals) in targets/…
93ca713 
…web.dart (flutter/flutter#125937)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
5816da8 [tool] consistently use environment (not globals) in targets/…
a766bf6 
…web.dart (flutter/flutter#125937)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
5816da8 [tool] consistently use environment (not globals) in targets/…
faaa35b 
…web.dart (flutter/flutter#125937)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
5816da8 [tool] consistently use environment (not globals) in targets/…
cd222ed 
…web.dart (flutter/flutter#125937)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
5816da8 [tool] consistently use environment (not globals) in targets/…
476a56d 
…web.dart (flutter/flutter#125937)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
5816da8 [tool] consistently use environment (not globals) in targets/…
71ef167 
…web.dart (flutter/flutter#125937)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
5816da8 [tool] consistently use environment (not globals) in targets/…
1b271bf 
…web.dart (flutter/flutter#125937)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
5816da8 [tool] consistently use environment (not globals) in targets/…
8ceb014 
…web.dart (flutter/flutter#125937)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
5816da8 [tool] consistently use environment (not globals) in targets/…
8137823 
…web.dart (flutter/flutter#125937)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
5816da8 [tool] consistently use environment (not globals) in targets/…
af6b6b3 
…web.dart (flutter/flutter#125937)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes
@yjbanov yjbanov Awaiting requested review from yjbanov

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Web applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kevmoo @eyebrowsoffire