fix(automations): restore automation deletion#2829
Merged
Conversation
Contributor
Greptile SummaryThis PR restores automation deletion by changing the modal order.
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| apps/emdash-desktop/src/renderer/features/automations/components/AutomationsView.tsx | Adds pending deletion state and defers the confirmation modal until the automation sheet has fully closed. |
Reviews (1): Last reviewed commit: "fix(automations): restore automation del..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restore automation deletion by closing the modal detail sheet before opening the global confirmation dialog. The sheet previously made sibling portals inert, preventing interaction with the confirmation action.
The selected automation is retained while the sheet closes, and its details reopen if confirmation is cancelled or the delete request fails.
Related issues
ENG-1682: Cannot delete automations
Testing
Screenshot/Recording (if applicable)
Not included; the change restores the existing deletion interaction.
Checklist
No automated test was added because the regression depends on interaction between separately portaled Base UI modal layers; the behavior was verified in the Electron app.