Skip to content

fix(automations): restore automation deletion#2829

Merged
arnestrickmann merged 1 commit into
mainfrom
arne/eng-1682-cannot-delete-automations
Jul 10, 2026
Merged

fix(automations): restore automation deletion#2829
arnestrickmann merged 1 commit into
mainfrom
arne/eng-1682-cannot-delete-automations

Conversation

@arnestrickmann

Copy link
Copy Markdown
Contributor

Description

Restore automation deletion by closing the modal detail sheet before opening the global confirmation dialog. The sheet previously made sibling portals inert, preventing interaction with the confirmation action.

The selected automation is retained while the sheet closes, and its details reopen if confirmation is cancelled or the delete request fails.

Related issues

ENG-1682: Cannot delete automations

Testing

  • Desktop typecheck
  • Desktop lint
  • Desktop format check
  • Full desktop build
  • Manual Electron verification of delete and cancel flows
  • git diff --check

Screenshot/Recording (if applicable)

Not included; the change restores the existing deletion interaction.

Checklist
  • I kept this PR small and focused
  • I ran a self-review before opening this PR
  • I ran the relevant local checks or explained why not
  • I updated docs when behavior or setup changed
  • I added or updated tests when behavior changed, or explained why not
  • I only added comments where the logic is not obvious
  • I used Conventional Commits for the commit message and PR title

No automated test was added because the regression depends on interaction between separately portaled Base UI modal layers; the behavior was verified in the Electron app.

@greptile-apps

greptile-apps Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR restores automation deletion by changing the modal order.

  • Stores the automation being deleted while the detail sheet closes.
  • Opens the global confirmation dialog after the sheet close completes.
  • Reopens the detail sheet when deletion is cancelled or the delete request fails.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
apps/emdash-desktop/src/renderer/features/automations/components/AutomationsView.tsx Adds pending deletion state and defers the confirmation modal until the automation sheet has fully closed.

Reviews (1): Last reviewed commit: "fix(automations): restore automation del..." | Re-trigger Greptile

@arnestrickmann
arnestrickmann merged commit c1c1de8 into main Jul 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant