fix(chat): prevent provider name clipping#2849
Merged
Merged
Conversation
janburzinski
marked this pull request as ready for review
July 13, 2026 12:40
Contributor
Greptile SummaryThis PR adjusts the chat composer model selector so provider names stay readable.
Confidence Score: 5/5This looks safe to merge after a small layout cleanup.
packages/ui/src/react/components/chat-composer/chat-composer.css.ts
|
| Filename | Overview |
|---|---|
| packages/ui/src/react/components/chat-composer/chat-composer.css.ts | Adds a model trigger style that prevents the selector from shrinking. |
| packages/ui/src/react/components/chat-composer/index.tsx | Applies the new trigger style and increases the clipped label line height. |
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
packages/ui/src/react/components/chat-composer/chat-composer.css.ts:204
**Model Trigger Stops Ellipsis**
When the composer is narrow or the selected provider/model name is long, `flexShrink: 0` keeps the trigger at its content width. That prevents the existing clipped label from shrinking enough to ellipsize, so the toolbar can overflow or push other controls out of the row instead of truncating the model name.
Reviews (1): Last reviewed commit: "fix(chat): avoid clipping model label de..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ENG-1832 by keeping the provider/model trigger from shrinking and giving its clipped text label enough line height for descenders.
Root cause
The model selector could shrink under toolbar pressure, and its text label used a unit line height inside an overflow-clipped span, which cut off descenders such as
g.screenshot
after:
