fix(chat-ui): support pasting image attachments#2862
Merged
Conversation
janburzinski
marked this pull request as ready for review
July 14, 2026 11:18
Contributor
Greptile SummaryThis PR adds pasted image support to the shared chat composer. The main changes are:
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| packages/ui/src/react/components/chat-composer/index.tsx | Adds paste-time image detection and routes pasted image files through the existing attachment callbacks. |
| apps/emdash-desktop/src/renderer/features/conversations/acp/acp-chat-panel.tsx | Adds ACP image format filtering, extension-based MIME inference, and user-facing feedback for unsupported pasted images. |
Reviews (9): Last reviewed commit: "fix(chat): handle generic clipboard imag..." | Re-trigger Greptile
Collaborator
Author
Collaborator
Author
Collaborator
Author
Collaborator
Author
Collaborator
Author
janburzinski
marked this pull request as draft
July 14, 2026 13:11
janburzinski
marked this pull request as ready for review
July 14, 2026 13:29
Collaborator
Author
Collaborator
Author
|
Cleaned this up to keep the PR focused on ENG-1852. Pasted images now just use the existing attachment flow, so we don’t need the extra helpers or API changes. |
Collaborator
Author
arnestrickmann
approved these changes
Jul 14, 2026
arnestrickmann
left a comment
Contributor
There was a problem hiding this comment.
lgtm - manually tested it - works!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The shared chat composer only handled drag-and-drop events, so Cmd+V image data never entered the existing attachment pipeline.
Screen recording
https://cap.link/1k3av3k59dbpst0