Skip to content

feat(server-utils): Rewrite @opentelemetry/instrumentation-hapi to orchestrion#21866

Merged
chargome merged 5 commits into
developfrom
charlygomez/js-2404-rewrite-opentelemetryinstrumentation-hapi-to-orchestrion
Jul 7, 2026
Merged

feat(server-utils): Rewrite @opentelemetry/instrumentation-hapi to orchestrion#21866
chargome merged 5 commits into
developfrom
charlygomez/js-2404-rewrite-opentelemetryinstrumentation-hapi-to-orchestrion

Conversation

@chargome

@chargome chargome commented Jun 30, 2026

Copy link
Copy Markdown
Member
  • Adds hapiChannelIntegration in @sentry/server-utils for injecting orchestrion channels
  • A start-only subscriber swaps route handlers / ext methods
  • Span-building helpers are ported OTel-free into hapi-utils.ts / hapi-types.ts (structural types, no @hapi/* runtime dep), HTTP attribute keys come from @sentry/conventions/attributes.

closes #20753

@chargome chargome self-assigned this Jun 30, 2026
@linear-code

linear-code Bot commented Jun 30, 2026

Copy link
Copy Markdown

JS-2404

@chargome chargome changed the title feat(server-utils): Rewrite @opentelemetry/instrumentation-hapi to orchestrion feat(server-utils): Rewrite @opentelemetry/instrumentation-hapi to orchestrion Jun 30, 2026
@chargome

Copy link
Copy Markdown
Member Author

bugbot run

@chargome

Copy link
Copy Markdown
Member Author

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 993f38b. Configure here.

@chargome chargome force-pushed the charlygomez/js-2404-rewrite-opentelemetryinstrumentation-hapi-to-orchestrion branch from 993f38b to fadc582 Compare July 1, 2026 10:30
@chargome chargome marked this pull request as ready for review July 1, 2026 12:20
@chargome chargome requested a review from a team as a code owner July 1, 2026 12:20
@chargome chargome requested review from JPeer264, andreiborza and mydea and removed request for a team July 1, 2026 12:20
@nicohrubec nicohrubec self-requested a review July 1, 2026 12:24
@chargome chargome force-pushed the charlygomez/js-2404-rewrite-opentelemetryinstrumentation-hapi-to-orchestrion branch from 93210f8 to 3a69ceb Compare July 2, 2026 13:05
@chargome chargome force-pushed the charlygomez/js-2404-rewrite-opentelemetryinstrumentation-hapi-to-orchestrion branch from 3a69ceb to 2ccdbe7 Compare July 3, 2026 08:06
@chargome chargome force-pushed the charlygomez/js-2404-rewrite-opentelemetryinstrumentation-hapi-to-orchestrion branch 2 times, most recently from fdcef3c to f4078e9 Compare July 3, 2026 08:52
chargome and others added 5 commits July 6, 2026 10:17
Rely on `createEsmAndCjsTests` auto-running the suite with orchestrion on
CI (#21911) instead of a manual instrument matrix: drop
`instrument-orchestrion.mjs` and branch the expected span origin on
`isOrchestrionEnabled()`.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@chargome chargome force-pushed the charlygomez/js-2404-rewrite-opentelemetryinstrumentation-hapi-to-orchestrion branch from f4078e9 to 931c07a Compare July 6, 2026 08:20
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

👋 @mydea, @JPeer264, @nicohrubec, @andreiborza — Please review this PR when you get a chance!

@chargome chargome merged commit 5e48cb0 into develop Jul 7, 2026
201 checks passed
@chargome chargome deleted the charlygomez/js-2404-rewrite-opentelemetryinstrumentation-hapi-to-orchestrion branch July 7, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rewrite @opentelemetry/instrumentation-hapi to orchestrion

2 participants