Replace mutable default arguments with the correct implementation.#677
Merged
Conversation
This will avoid potential sharing states problem through different instances of the EventHandler
Collaborator
|
Hello @Sraw , Could you add a line and your GitHub nick into https://github.com/gorakhargosh/watchdog/blob/master/changelog.rst 🙏? |
Collaborator
|
Thanks 👍 |
CCP-Aporia
pushed a commit
to CCP-Aporia/watchdog
that referenced
this pull request
Aug 13, 2020
…rakhargosh#677) * Replace mutable default arguments with the correct implementation. This will avoid potential sharing states problem through different instances of the EventHandler * update changelog.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will avoid potential sharing state problems through different instances of the EventHandler.
The problem is very unlikely to happen, but whatever we fix a potential bug.