test: validate provider routes survive engine rebuild with global middleware#132
Merged
Conversation
…dleware Add a RouteProvider that registers GET /provider-route in its Boot() method and a test asserting it returns 200. This validates the fix from goravel/framework#1508 where configureMiddleware was moved between Register() and Boot() to prevent route loss.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Boot()were silently lost when the application had global middleware configuredRouteProviderthat registersGET /provider-routeinBoot()and a test verifying it responds correctly8c6802eto pick up the fix from fix: reorder configureMiddleware before Boot so provider routes survive engine rebuild (#975) framework#1508Why
goravel/framework#1508 fixed a bug where
configureMiddlewareran afterBoot(), causingSetGlobalMiddlewareto rebuild the route engine and silently discard routes registered by service providers during boot. The fix reordersconfigureMiddlewareto run betweenRegister()andBoot(), so the engine is set up with global middleware before providers register their routes.The example repo had no coverage for this ordering — a provider that registers routes in
Boot()would have returned 404 without the fix. The newRouteProviderand test ensure this contract is preserved.