feat: [#719] package:install support install goravel/framework facades#1172
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1172 +/- ##
==========================================
- Coverage 68.54% 68.52% -0.03%
==========================================
Files 223 225 +2
Lines 14475 14600 +125
==========================================
+ Hits 9922 10004 +82
- Misses 4178 4218 +40
- Partials 375 378 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hwbrzzl
commented
Aug 24, 2025
|
|
||
| info, _ := debug.ReadBuildInfo() | ||
| structName := str.Of(fileName).Prepend("m_").Studly().String() | ||
| if err = modify.GoFile(path.Database("kernel.go")). |
Contributor
Author
There was a problem hiding this comment.
path should not be used in framework, given it uses App directly.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: b6dbe88 | Previous: b8e3a32 | Ratio |
|---|---|---|---|
BenchmarkFile_ReadWrite |
263774 ns/op 6258 B/op 99 allocs/op |
173029 ns/op 6258 B/op 99 allocs/op |
1.52 |
BenchmarkFile_ReadWrite - ns/op |
263774 ns/op |
173029 ns/op |
1.52 |
This comment was automatically generated by workflow using github-action-benchmark.
hwbrzzl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Closes goravel/goravel#719
This pull request introduces several changes to improve the package and facade installation process, refactor service provider relationships, and streamline command registration in the Goravel framework. The most notable updates are the new facade installation logic, removal of the
FacadeToPathmap from bindings, and enhancements to the database migration and seeder commands to use the application context.✅ Checks