Skip to content

fix: Incorrect handling of nested relationships during relationship loading.#1304

Merged
hwbrzzl merged 2 commits into
goravel:masterfrom
wyicwx:fix/nested-eager-loading
Dec 17, 2025
Merged

fix: Incorrect handling of nested relationships during relationship loading.#1304
hwbrzzl merged 2 commits into
goravel:masterfrom
wyicwx:fix/nested-eager-loading

Conversation

@wyicwx

@wyicwx wyicwx commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

📑 Description

This PR fixes an issue where the ORM could not handle nested associations when using load().

✅ Checks

  • Added test cases for my code

@wyicwx
wyicwx requested a review from a team as a code owner December 16, 2025 06:04
@codecov

codecov Bot commented Dec 16, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.16%. Comparing base (6e3ccd0) to head (def5caa).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1304      +/-   ##
==========================================
+ Coverage   69.01%   69.16%   +0.14%     
==========================================
  Files         277      276       -1     
  Lines       16164    16168       +4     
==========================================
+ Hits        11156    11182      +26     
+ Misses       4534     4510      -24     
- Partials      474      476       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread database/gorm/query.go

@hwbrzzl hwbrzzl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@hwbrzzl
hwbrzzl merged commit a068d79 into goravel:master Dec 17, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants