fix: [#942] use connection driver for schema#1489
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1489 +/- ##
==========================================
+ Coverage 69.38% 69.46% +0.07%
==========================================
Files 378 378
Lines 29683 29710 +27
==========================================
+ Hits 20597 20639 +42
+ Misses 8140 8118 -22
- Partials 946 953 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
db:wipe --databasereuses the resolved schema connection for all wipe operations.Closes goravel/goravel#942
Why
Applications can configure multiple database connections with different drivers. Schema operations should compile metadata queries using the selected connection driver instead of the default connection driver.
Before this change,
facades.Schema().Connection("OtherDBMS")executed against the selected connection but compiled schema SQL with the default driver. After this change, both facade schema calls anddb:wipe --databaseuse the selected connection driver metadata.