Skip to content

Test common refactoring#1178

Merged
VakarisZ merged 6 commits into
developfrom
test_common_refactoring
May 20, 2021
Merged

Test common refactoring#1178
VakarisZ merged 6 commits into
developfrom
test_common_refactoring

Conversation

@VakarisZ

Copy link
Copy Markdown
Contributor

What does this PR do?

Further improves the UT's infrastructure by:
Moved fixtures left in production code to the relevant test folder
Moved profiler to tests
Moved unit tests under a separate folder to distinguish them from infrastructure

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Have you successfully tested your changes locally? Elaborate:

    Tested by running all of the unit tests (all pass, one gets skipped for not running on Windows)

@VakarisZ VakarisZ requested a review from shreyamalviya May 19, 2021 07:15
@VakarisZ VakarisZ force-pushed the test_common_refactoring branch from 3b992f0 to 0ab91ef Compare May 20, 2021 07:24
@codecov

codecov Bot commented May 20, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1178 (e978823) into develop (832453f) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1178      +/-   ##
===========================================
+ Coverage    28.80%   28.91%   +0.10%     
===========================================
  Files          417      418       +1     
  Lines        12762    12780      +18     
===========================================
+ Hits          3676     3695      +19     
+ Misses        9086     9085       -1     
Impacted Files Coverage Δ
.../unit_tests/infection_monkey/telemetry/conftest.py 100.00% <ø> (ø)
...nit_tests/monkey_island/cc/environment/conftest.py 100.00% <ø> (ø)
monkey/tests/unit_tests/monkey_island/conftest.py 100.00% <ø> (ø)
...nkey/tests/unit_tests/monkey_island/cc/conftest.py 100.00% <100.00%> (ø)
.../unit_tests/monkey_island/cc/mongomock_fixtures.py 100.00% <100.00%> (ø)
monkey/__init__.py 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 832453f...e978823. Read the comment docs.

@VakarisZ VakarisZ merged commit b02c006 into develop May 20, 2021
@VakarisZ VakarisZ deleted the test_common_refactoring branch May 20, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants