Add API endpoint for ransomware report#1297
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1297 +/- ##
===========================================
- Coverage 30.68% 30.66% -0.02%
===========================================
Files 449 450 +1
Lines 13467 13475 +8
===========================================
Hits 4132 4132
- Misses 9335 9343 +8
Continue to review full report at Codecov.
|
mssalvatore
requested changes
Jul 5, 2021
mssalvatore
left a comment
mssalvatore
left a comment
Collaborator
There was a problem hiding this comment.
This should get a changelog entry, since it's changing Monkey Island's API.
| class RansomwareReport(flask_restful.Resource): | ||
| @jwt_required | ||
| def get(self): | ||
| return jsonify({"show": True, "report": None}) |
Collaborator
There was a problem hiding this comment.
The back end should not be making decisions about what the front end should show. It's the backend's job to report what data it has. It's the frontend's job to decide how to display that data.
ilija-lazoroski
approved these changes
Jul 6, 2021
mssalvatore
approved these changes
Jul 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#1240
PR Checklist
Was the CHANGELOG.md updated to reflect the changes?Was the documentation framework updated to reflect the changes?Testing Checklist
Added relevant unit tests?If applicable, add screenshots or log transcripts of the feature working