Generate report with remediation_suggestion#2885
Merged
Merged
Conversation
shreyamalviya
force-pushed
the
2857-dynamically-generate-report
branch
from
fc98531 to
870c209
Compare
Contributor
Author
|
Updated screenshot: |
VakarisZ
force-pushed
the
2857-modify-report-to-send-remediation-suggestions
branch
3 times, most recently
from
18c7096 to
addc1f5
Compare
Base automatically changed from
2857-modify-report-to-send-remediation-suggestions
to
develop
January 26, 2023 14:40
VakarisZ
force-pushed
the
2857-dynamically-generate-report
branch
from
929d5d1 to
ebdb1e3
Compare
…diation suggestions
Structure of the issue changed, so we can simplify the security report and improve markdown display
These improvements account for the possibility of missing descriptions or remediations
Segmentation issues get a separate section because the overview is going away. Overview is going away, because exploiter plugins won't have an overview information
Issue set is not needed, all issues are already being sent as "issues" in recommendations
Issues like "shared_password_domain" and "strong_users_on_crit" are not being generated on the back end. It doesn't make sense to keep the overview code on the front end
The overview is gone and this issue is redundant: any cross segemntation communications should be reported the same way, regardless if it was island or agents
Zerologon password restoration was moved to the remediation section where it belongs
Report refactoring left some unused code. It's mainly related to the removal of overview section in reports
VakarisZ
force-pushed
the
2857-dynamically-generate-report
branch
from
4c8e92f to
d53d402
Compare
ilija-lazoroski
approved these changes
Jan 27, 2023
Contributor
Author
|
Tested that non-plugin issues are shown as expected: |
Codecov ReportBase: 65.71% // Head: 65.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2885 +/- ##
===========================================
+ Coverage 65.71% 65.72% +0.01%
===========================================
Files 415 414 -1
Lines 11910 11870 -40
===========================================
- Hits 7827 7802 -25
+ Misses 4083 4068 -15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
shreyamalviya
force-pushed
the
2857-dynamically-generate-report
branch
from
0c668be to
074e2c0
Compare
VakarisZ
reviewed
Jan 31, 2023
Comment on lines
+289
to
+290
| contact <a href='mailto://labs@guardicore.com' className='no-print'>labs@guardicore.com</a> | ||
| <div className='force-print' style={{ display: 'none' }}>labs@guardicore.com</div>. |
Contributor
There was a problem hiding this comment.
This probably should be changed to support@infectionmonkey.com, but let's not cram more changes into this PR. Typos in the report have nothing to do with plugins.
Contributor
Author
There was a problem hiding this comment.
Right, I'll open another PR with these changes.
VakarisZ
approved these changes
Jan 31, 2023
shreyamalviya
force-pushed
the
2857-dynamically-generate-report
branch
from
074e2c0 to
b21d995
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a part of #2857
PR Checklist
Testing Checklist