Skip to content

3231 resolve hostname with dashes#3352

Merged
mssalvatore merged 2 commits into
developfrom
3231-resolve-hostname-with-dashes
May 17, 2023
Merged

3231 resolve hostname with dashes#3352
mssalvatore merged 2 commits into
developfrom
3231-resolve-hostname-with-dashes

Conversation

@ilija-lazoroski

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes #3231.

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@shreyamalviya shreyamalviya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the commit message to something more helpful/descriptive too.

Comment thread monkey/common/network/network_range.py Outdated
Comment thread CHANGELOG.md Outdated
ilija-lazoroski added a commit that referenced this pull request May 17, 2023
@ilija-lazoroski ilija-lazoroski force-pushed the 3231-resolve-hostname-with-dashes branch 2 times, most recently from 2a42b20 to d37ce35 Compare May 17, 2023 12:03
Comment thread monkey/common/network/network_range.py Outdated
Comment thread monkey/common/network/network_range.py Outdated
ilija-lazoroski added a commit that referenced this pull request May 17, 2023
@ilija-lazoroski ilija-lazoroski force-pushed the 3231-resolve-hostname-with-dashes branch from d37ce35 to 624eabe Compare May 17, 2023 13:06
@ilija-lazoroski ilija-lazoroski force-pushed the 3231-resolve-hostname-with-dashes branch from 624eabe to 82748b0 Compare May 17, 2023 13:06
@mssalvatore mssalvatore merged commit 767e7c3 into develop May 17, 2023
@mssalvatore mssalvatore deleted the 3231-resolve-hostname-with-dashes branch May 17, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scan target hostnames with dashes are not resolved

3 participants