Add email address identity type#3354
Conversation
|
|
||
| const emptyRegex = /^$/ | ||
|
|
||
| const emailAddressRegex = new RegExp(/^[\S\-.]+@([\w-]+\.)+[\w-]{2,4}$/) |
There was a problem hiding this comment.
Not totally sure about this. What all do we want to accept?
There was a problem hiding this comment.
Well, here's the regex from the RFC http://www.ex-parrot.com/~pdw/Mail-RFC822-Address.html
There was a problem hiding this comment.
Seriously though, is there a library that does this validation? Maybe @ordabach can help?
There was a problem hiding this comment.
There was a problem hiding this comment.
Looks good to me. Going with this.
mssalvatore
left a comment
mssalvatore
left a comment
There was a problem hiding this comment.
We need to check for any code that assumes Username is the only identity.
shreyamalviya
force-pushed
the
3270-add-email-address-identity-type
branch
from
fdbd013 to
5573380
Compare
mssalvatore
left a comment
mssalvatore
left a comment
There was a problem hiding this comment.
Approved, pending an ETE test with email addresses to make sure we didn't introduce any issues.
shreyamalviya
force-pushed
the
3270-add-email-address-identity-type
branch
from
924134b to
14727c5
Compare
|
ETE tests fail because flask dependencies were upgraded in Pipfile.lock. Flask v2.3.0 removes JSONEncoder. We'll need to pin the flask version and try to run ETE tests again. |
shreyamalviya
force-pushed
the
3270-add-email-address-identity-type
branch
2 times, most recently
from
ba63e75 to
6814a04
Compare
All tests except SNMP pass. |
mssalvatore
force-pushed
the
3270-add-email-address-identity-type
branch
from
6814a04 to
b6143f1
Compare
3 participants
What does this PR do?
Fixes #3270
PR Checklist
Was the documentation framework updated to reflect the changes?Testing Checklist
Do all end-to-end tests pass?