Fix plugin type value in grid#3649
Conversation
| } | ||
| ] | ||
|
|
||
| enum pluginTypeHumanReadable { |
There was a problem hiding this comment.
Do we need an enum for that?
Is there a chance that the type coming from the server will have a different name without the underscore?
E.g.:
from server --> Credentials_Collector
in ui --> Credentials Collector
can't we just replace the underscore with space and cap each word?
There was a problem hiding this comment.
Since these are values that aren't expected to change, I'd rather skip the extra logic. Even if something about how we display the name ever changes, this is easier to rework than trying to modify and debug the logic.
There was a problem hiding this comment.
Aren't expected by who? The table is a display element, nothing should expect it's columns to correspond to the plugin data.
VakarisZ
left a comment
There was a problem hiding this comment.
Hack. We need to use plugin data, not table row data for actions. I'm working on fixing this
VakarisZ
left a comment
There was a problem hiding this comment.
Hack. We need to use plugin data, not table row data for actions. I'm working on fixing this
Example: Credentials_Collector -> Credentials Collector
5ac46d3 to
b2e4044
Compare
What does this PR do?
Make plugin type values human readable in plugin grid (removes underscores)
#3418
PR Checklist
Was the CHANGELOG.md updated to reflect the changes?Was the documentation framework updated to reflect the changes?Testing Checklist
Added relevant unit tests?Do all unit tests pass?Do all end-to-end tests pass?