Skip to content

Fix plugin type value in grid#3649

Merged
VakarisZ merged 4 commits into
3418-plugin-installation-screenfrom
3418-fix-plugin-type-value-in-grid
Sep 4, 2023
Merged

Fix plugin type value in grid#3649
VakarisZ merged 4 commits into
3418-plugin-installation-screenfrom
3418-fix-plugin-type-value-in-grid

Conversation

@shreyamalviya

Copy link
Copy Markdown
Contributor

What does this PR do?

Make plugin type values human readable in plugin grid (removes underscores)
#3418

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested UI

  • If applicable, add screenshots or log transcripts of the feature working

image

@shreyamalviya shreyamalviya mentioned this pull request Sep 4, 2023
38 tasks
}
]

enum pluginTypeHumanReadable {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need an enum for that?

Is there a chance that the type coming from the server will have a different name without the underscore?
E.g.:
from server --> Credentials_Collector
in ui --> Credentials Collector

can't we just replace the underscore with space and cap each word?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are values that aren't expected to change, I'd rather skip the extra logic. Even if something about how we display the name ever changes, this is easier to rework than trying to modify and debug the logic.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't expected by who? The table is a display element, nothing should expect it's columns to correspond to the plugin data.

@VakarisZ VakarisZ left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hack. We need to use plugin data, not table row data for actions. I'm working on fixing this

VakarisZ
VakarisZ approved these changes Sep 4, 2023

@VakarisZ VakarisZ left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hack. We need to use plugin data, not table row data for actions. I'm working on fixing this

@VakarisZ VakarisZ force-pushed the 3418-fix-plugin-type-value-in-grid branch from 5ac46d3 to b2e4044 Compare September 4, 2023 10:19

@VakarisZ VakarisZ left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@VakarisZ VakarisZ merged commit 2d95b35 into 3418-plugin-installation-screen Sep 4, 2023
@VakarisZ VakarisZ deleted the 3418-fix-plugin-type-value-in-grid branch September 4, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants