SMB vulnerable port fix#664
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #664 +/- ##
===========================================
- Coverage 56.92% 56.62% -0.31%
===========================================
Files 117 120 +3
Lines 3926 4044 +118
===========================================
+ Hits 2235 2290 +55
- Misses 1691 1754 +63
Continue to review full report at Codecov.
|
ShayNehmad
reviewed
May 26, 2020
Comment on lines
+166
to
+171
|
|
||
| def set_vulnerable_port(self, host: VictimHost): | ||
| if 'tcp-445' in self.host.services: | ||
| self.vulnerable_port = "445" | ||
| elif 'tcp-139' in self.host.services: | ||
| self.vulnerable_port = "139" |
Contributor
There was a problem hiding this comment.
There's a hidden temporal coupling here. What if none of these services are in the list?
Contributor
Author
There was a problem hiding this comment.
vulnerable port remains none, which is fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
Fixes SMB exploiter not passing vulnerable port (thus causing redundant exploitations)
Checklist
Proof that it works