Py import order travis#727
Merged
Merged
Conversation
fix issues in envs/ as well
| - pip install -r monkey/monkey_island/requirements.txt # for unit tests | ||
| - pip install flake8 pytest dlint # for next stages | ||
| - pip install flake8 pytest dlint flake8-import-order # for next stages | ||
| - pip install coverage # for code coverage |
Contributor
There was a problem hiding this comment.
We need to replace this with isort too
Codecov Report
@@ Coverage Diff @@
## develop #727 +/- ##
===========================================
- Coverage 59.89% 59.85% -0.04%
===========================================
Files 147 147
Lines 4787 4783 -4
===========================================
- Hits 2867 2863 -4
Misses 1920 1920
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
Fixes #725.
Checklist