150/resize network map#931
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #931 +/- ##
========================================
Coverage 18.54% 18.54%
========================================
Files 338 338
Lines 11483 11483
========================================
Hits 2130 2130
Misses 9353 9353 Continue to review full report at Codecov.
|
| return (<Graph graph={this.props.graph} options={newOptions} events={this.props.events}/>) | ||
| return ( | ||
| <div class={'net-graph-wrapper'}> | ||
| <Graph graph={this.props.graph} options={newOptions} events={this.props.events}/> |
There was a problem hiding this comment.
Tried it like this?
| <Graph graph={this.props.graph} options={newOptions} events={this.props.events}/> | |
| <Graph graph={this.props.graph} options={newOptions} events={this.props.events} className={'net-graph-wrapper'}/> |
There was a problem hiding this comment.
@VakarisZ Yeah, it doesn't work because the Graph component ignores the className property. https://github.com/crubier/react-graph-vis/blob/b86b4ebfe2112f3a6ae946ab3806c7d995502f3a/lib/index.js#L256-L260
I could add the style instead of adding a class name, but I'd rather we control as much of the style in .css files as possible, rather than having them hard coded in the JSX.
What does this PR do?
Fixes #150 - Scale Monkey Island map to window size
PR Checklist
Testing Checklist