Fix openglcompute app#1679
Merged
Merged
Conversation
Made it use Halide::Buffer. While doing this I discovered that the vector support in OpenGLCompute codegen was broken, and made a dangerous assumption anyway (all vector access is aligned), so I neutered it for now. It needs a pass that actually detects if all buffer access is aligned dense vectors, and if so, declares the buffer as an array of vectors.
Contributor
|
LGTM. Probably should open an issue re the vector alignment wrongness so it doesn't get forgotten. |
dsharletg
reviewed
Dec 13, 2016
| @@ -1,15 +1,17 @@ | |||
| CXX-host ?= c++ | |||
| CXX-arm-64-android ?= $(ANDROID_NDK_HOME)/toolchains/aarch64-linux-android-4.9/prebuilt/linux-x86_64/bin/aarch64-linux-android-c++ | |||
Contributor
There was a problem hiding this comment.
Did you intend to commit the changes to the simd_op_check makefile on this branch?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made it use Halide::Buffer.
While doing this I discovered that the vector support in OpenGLCompute
codegen was broken, and made a dangerous assumption anyway (all vector
access is aligned), so I neutered it for now. It needs a pass that
actually detects if all buffer access is aligned dense vectors, and if
so, declares the buffer as an array of vectors.