Fix hoist_storage not handling condition correctly.#8123
Merged
steven-johnson merged 1 commit intoFeb 27, 2024
Conversation
The allocation condition wasn't getting relaxed over the scope and loop vars like the extents were.
vksnk
approved these changes
Feb 26, 2024
Contributor
|
Ready to land pending green |
steven-johnson
deleted the
abadams/fix_hoist_storage_allocation_condition
branch
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The allocation condition wasn't getting relaxed over the scope and loop vars like the extents were.
This fix is included in the rewrite_skip_stages PR, but it's a bug on main, so I'm opening it as a fresh PR on main in case the other branch gets stalled.