Add NFData and NFData1 instances for Compose#30
Conversation
|
Sorry for taking so long to get around to this! I agree that using Thanks! |
|
No problem, I have updated the branch with the additional instances. |
|
Looks good to me. @hvr, should we merge this now, or wait until after the imminent release of the next |
|
@RyanGlScott if we're confident that these instances are correct, I see no reason to delay (there's a few other things I want to cleanup before I feel good enough about tagging 1.4.3) ... while GHC 8.2.1 RC1 won't have them, it's a given we're gonna have a GHC 8.2.1 RC2... and that's gonna have the final deepseq-1.4.3 |
Plus some minor code cleanup
Please review. Not sure whether the NFData instance should build on the NFData1 instance or not.