Skip to content

Add instances for the indexed TypeRep (+ Module)#83

Closed
goldfirere wants to merge 1 commit into
haskell:masterfrom
goldfirere:master
Closed

Add instances for the indexed TypeRep (+ Module)#83
goldfirere wants to merge 1 commit into
haskell:masterfrom
goldfirere:master

Conversation

@goldfirere

Copy link
Copy Markdown

Fixes #82, along with a bonus instance.

@mixphix

mixphix commented May 3, 2022

Copy link
Copy Markdown
Collaborator

This fails on 8.0.2, presumably because that module didn't exist on that GHC version. I'm hesitant to drop support just for this patch, is there a way around it?

@goldfirere

Copy link
Copy Markdown
Author

Is some CPP allowed?

@mixphix

mixphix commented May 3, 2022

Copy link
Copy Markdown
Collaborator

I don't see why not; there's plenty of workarounds already.

mixphix pushed a commit that referenced this pull request Aug 26, 2022
add CPP to fix CI for 8.0.2

fix cpp for Type.Reflection
@mixphix

mixphix commented Aug 26, 2022

Copy link
Copy Markdown
Collaborator

I implemented these changes in 8215dcb, and fixed the failing CI for 8.0.2.

@mixphix mixphix closed this Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add instance for the indexed TypeRep from Type.Reflection

2 participants