Skip to content

Use less CPP#47

Merged
snoyberg merged 20 commits into
masterfrom
less-cpp
Nov 17, 2015
Merged

Use less CPP#47
snoyberg merged 20 commits into
masterfrom
less-cpp

Conversation

@snoyberg

@snoyberg snoyberg commented Nov 3, 2015

Copy link
Copy Markdown
Collaborator

Major changes:

  • Most Windows-specific and POSIX-specific code live in their own modules
  • No more GLASGOW_HASKELL conditionals, since it didn't work anyway

This now compiles without warnings on Linux and Windows, addressing Simon's original concern.

@hvr would you mind reviewing?

Comment thread System/Process.hsc

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this still be here? Unless InterruptibleFFI is a portable extension now? or process only supports GHC?

EDIT: Nvm, I see support for non-GHC compilers is being dropped.

snoyberg added a commit that referenced this pull request Nov 17, 2015
@snoyberg snoyberg merged commit e5a7ee3 into master Nov 17, 2015
@snoyberg snoyberg deleted the less-cpp branch November 13, 2016 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants