Adding label distribution measurement#202
Merged
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
lvwerra
reviewed
Jul 26, 2022
lvwerra
left a comment
lvwerra
left a comment
Member
There was a problem hiding this comment.
Thanks for adding this! Overall looks good, left a few nits. Main change I am proposing is using scipy instead of pandas for the skew computation since it avoids wrapping in a Series object.
Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
removing imdb example from docstring
lvwerra
reviewed
Jul 26, 2022
Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
removing if statement
adding scipy bibtex
updating references
lvwerra
approved these changes
Jul 26, 2022
mathemakitten
pushed a commit
that referenced
this pull request
Aug 3, 2022
* adding label distribution measurement * removing comment * Update measurements/label_distribution/label_distribution.py Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com> * Update measurements/label_distribution/label_distribution.py Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com> * Update measurements/label_distribution/requirements.txt Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com> * Update label_distribution.py removing imdb example from docstring * fixing style * Update README.md * Update measurements/label_distribution/README.md Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com> * Update label_distribution.py removing if statement * Update label_distribution.py adding scipy bibtex * Update README.md updating references * Update label_distribution.py * Update label_distribution.py * one final style and quality? Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally adding that label distribution measurement! thanks @lvwerra for all your guidance 🤗