Add a fingerprint for each EvaluationModule#206
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
lhoestq
reviewed
Jul 28, 2022
lhoestq
left a comment
Member
There was a problem hiding this comment.
In datasets we use fingerprint to identify data, while we use hash to identify dataset scripts. For example a DatasetBuilder has a hash that identifies the code of the dataset script it is going to run.
Not a strong opinion but I think you can also name it hash for consistency
Member
|
Sounds good to me - also have no strong opinion :) |
Contributor
Author
|
Renamed, thanks for the clarification on hash vs. fingerprint! |
mathemakitten
added a commit
that referenced
this pull request
Aug 3, 2022
* Add fingerprint for Hub modules * Rename evaluation module fingerprint to _hash * fix typo Co-authored-by: helen <helen@huggingface.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to support #126 we need to fingerprint whichever EvaluationModule (metric, measurement, etc) we're using for later reproducibility.
This extracts the already-computed hash from each EvaluationModule and makes it easy to access in the
evaluation_clsviamodule._fingerprint, similar to how indatasetsyou can dods._fingerprint.Test via