Skip to content

Fix spaces tagging#217

Merged
lvwerra merged 2 commits into
mainfrom
fix-spaces-tagging
Jul 28, 2022
Merged

Fix spaces tagging#217
lvwerra merged 2 commits into
mainfrom
fix-spaces-tagging

Conversation

@lvwerra

@lvwerra lvwerra commented Jul 28, 2022

Copy link
Copy Markdown
Member

The add_tag method does not push unless a remote is specified, so the tags weren't pushed. Added the remote as well as some more logging.

@lvwerra
lvwerra requested a review from lhoestq July 28, 2022 08:44
@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Jul 28, 2022

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@lhoestq lhoestq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch !

@lvwerra
lvwerra merged commit a634a92 into main Jul 28, 2022
@lvwerra
lvwerra deleted the fix-spaces-tagging branch July 28, 2022 12:16
mathemakitten pushed a commit that referenced this pull request Aug 3, 2022
* make sure tags are pushed

* add more logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants