Skip to content

Unpin rouge_score#220

Merged
lvwerra merged 1 commit into
mainfrom
albertvillanova-patch-1
Aug 4, 2022
Merged

Unpin rouge_score#220
lvwerra merged 1 commit into
mainfrom
albertvillanova-patch-1

Conversation

@albertvillanova

Copy link
Copy Markdown
Member

Once the issue has been fixed in their side with version 0.1.2, we can unpin it:

OK I've verified that 0.1.2 works in colab. Today I learned that colab uses python 3.7.

Follow-up of:

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Jul 29, 2022

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@lvwerra lvwerra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused by your message: can we already merge this? :)

@albertvillanova

Copy link
Copy Markdown
Member Author

Yes: our CIs pip install the latest version of rouge_score

  • Before: their latest version was 0.0.7, which had a bug and was not importable
  • Now: their latest version is 0.1.2, which fixed their bug and is importable
    • Our CI passes with this version

@lvwerra

lvwerra commented Aug 4, 2022

Copy link
Copy Markdown
Member

Thanks @albertvillanova!

@lvwerra
lvwerra merged commit fdb6dbf into main Aug 4, 2022
@lvwerra
lvwerra deleted the albertvillanova-patch-1 branch August 4, 2022 12:18
mathemakitten pushed a commit that referenced this pull request Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants