Skip to content

Fix loading error#222

Merged
lvwerra merged 3 commits into
mainfrom
fix-loading-error
Jul 29, 2022
Merged

Fix loading error#222
lvwerra merged 3 commits into
mainfrom
fix-loading-error

Conversation

@lvwerra

@lvwerra lvwerra commented Jul 29, 2022

Copy link
Copy Markdown
Member

When switching from GitHub to Hugging Face Hub as a source of the scripts in #180 the error changed when a file is not found from FileNotFoundError (GitHub) to ConnectionError. When the module_type needs to be inferred this fails as the error is not caught.

This PR should fix this.

@lvwerra
lvwerra requested a review from sashavor July 29, 2022 13:04
@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Jul 29, 2022

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@sashavor sashavor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the loading bug! yay! 💪

@lvwerra
lvwerra merged commit 4ed51c9 into main Jul 29, 2022
@lvwerra
lvwerra deleted the fix-loading-error branch July 29, 2022 13:20
mathemakitten pushed a commit that referenced this pull request Aug 3, 2022
* fix because hub throws `ConnectionError`

* fix error message

* update second catch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants