Fix loading error#222
Merged
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
sashavor
approved these changes
Jul 29, 2022
sashavor
left a comment
Contributor
There was a problem hiding this comment.
This fixes the loading bug! yay! 💪
mathemakitten
pushed a commit
that referenced
this pull request
Aug 3, 2022
* fix because hub throws `ConnectionError` * fix error message * update second catch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When switching from GitHub to Hugging Face Hub as a source of the scripts in #180 the error changed when a file is not found from
FileNotFoundError(GitHub) toConnectionError. When themodule_typeneeds to be inferred this fails as the error is not caught.This PR should fix this.