Fix enforce string#230
Merged
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
sashavor
approved these changes
Aug 4, 2022
sashavor
left a comment
sashavor
left a comment
Contributor
There was a problem hiding this comment.
Awesome! Super useful, thanks! 🚀
mathemakitten
approved these changes
Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some casting operations throw
ValueErrors while othersTypeErrors. With this PR both are cought when inferring the type to make sure the iterative testing of feature types doesn't get interrupted. We didn't catch this so far because we hadSequencefirst andstrsecond. I updated the test to include both cases, which would fail before and passes now.