Remove handle_impossible_answer from the default PIPELINE_KWARGS in the question answering evaluator#272
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
fxmarty
force-pushed
the
fix-qa-evaluator-test
branch
from
August 23, 2022 09:57
f607f49 to
3970fa2
Compare
fxmarty
force-pushed
the
fix-qa-evaluator-test
branch
from
August 23, 2022 14:58
0d5f4ef to
f72a969
Compare
lvwerra
approved these changes
Aug 24, 2022
lvwerra
left a comment
lvwerra
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix! I think maybe having this as a class attribute in the first place is not ideal and we should rather do it in the __init__ so this is not shared across instances of the same evaluator. But we can fix this in a separate PR.
mathemakitten
pushed a commit
that referenced
this pull request
Aug 24, 2022
…in the question answering evaluator (#272) * fix handle_impossible_answer arg in question answering evaluator * add default pipeline kwargs for all subclasses of evalautor * trigger actions
mathemakitten
pushed a commit
that referenced
this pull request
Sep 23, 2022
…in the question answering evaluator (#272) * fix handle_impossible_answer arg in question answering evaluator * add default pipeline kwargs for all subclasses of evalautor * trigger actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This argument should be set depending on whether we infer a dataset in the format of squad_v1 or squad_v2, hence remove the default.
Fixing as well the depreciation of
logger.warnforlogger.warning.cc @mathemakitten