Skip to content

Fix HONEST yaml#303

Merged
sashavor merged 1 commit into
mainfrom
lvwerra-patch-1
Oct 4, 2022
Merged

Fix HONEST yaml#303
sashavor merged 1 commit into
mainfrom
lvwerra-patch-1

Conversation

@lvwerra

@lvwerra lvwerra commented Sep 29, 2022

Copy link
Copy Markdown
Member

No description provided.

@lvwerra
lvwerra requested a review from sashavor September 29, 2022 13:23
sashavor
sashavor approved these changes Sep 29, 2022
View reviewed changes

@sashavor sashavor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this! the description needs to start with a tab?

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Sep 29, 2022 •
edited
Loading

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@mathemakitten

mathemakitten commented Oct 4, 2022

Copy link
Copy Markdown
Contributor

Sorry I missed this! the description needs to start with a tab?

See discussion in #296 — I'm trying to figure out if we can trigger this test to run on only new/changed files instead of all of them. For the moment, you can verify new YAML files manually with

with open('README.md') as f_yaml:
    x = yaml.safe_load_all(f_yaml)
    y = next(x)  # if it's invalid yaml then it'll throw an error

@sashavor
sashavor merged commit 8e76263 into main Oct 4, 2022
@sashavor
sashavor deleted the lvwerra-patch-1 branch October 4, 2022 17:28
NimaBoscarino pushed a commit that referenced this pull request Oct 17, 2022
@lvwerra @NimaBoscarino
Fix HONEST yaml (#303)
c075c02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@sashavor sashavor sashavor approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lvwerra @HuggingFaceDocBuilderDev @mathemakitten @sashavor