Skip to content

Use HTML relative paths for tiles#318

Merged
lvwerra merged 1 commit into
mainfrom
use-relative-urls
Oct 10, 2022
Merged

Use HTML relative paths for tiles#318
lvwerra merged 1 commit into
mainfrom
use-relative-urls

Conversation

@lewtun

@lewtun lewtun commented Oct 10, 2022

Copy link
Copy Markdown
Member

This PR replaces the absolute paths in the landing page tiles with relative ones so that one can test navigation both locally in and in future PRs (see here for an example PR where the links don't work).

I encountered this while working on the optimum docs and figured I'd fix it elsewhere too :)

Internal Slack thread: https://huggingface.slack.com/archives/C02GLJ5S0E9/p1665129710176619

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Oct 10, 2022

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@lvwerra lvwerra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 🚀

@lvwerra
lvwerra merged commit a785429 into main Oct 10, 2022
@lvwerra
lvwerra deleted the use-relative-urls branch October 10, 2022 08:15
NimaBoscarino pushed a commit that referenced this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants