try main if tag does not work#322
Merged
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
lhoestq
reviewed
Oct 12, 2022
lhoestq
left a comment
Member
There was a problem hiding this comment.
good catch ^^
Though if the user explicitly passed revision I don't think we should try main
Member
Author
|
The attribute evaluate/src/evaluate/loading.py Line 485 in 4d61255 So I think we should never overwrite whatever the user explicitly passed. Does that make sense? |
lhoestq
approved these changes
Oct 13, 2022
lhoestq
left a comment
Member
There was a problem hiding this comment.
Sorry I misread your code, LGTM !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous fix #314 ignores the fact that some repos (especially community) might not have tags. We should fall back to
mainin that case.