Skip to content

Matthews correlation coefficient#362

Merged
lvwerra merged 8 commits into
huggingface:mainfrom
sanderland:matthews
Nov 17, 2022
Merged

Matthews correlation coefficient#362
lvwerra merged 8 commits into
huggingface:mainfrom
sanderland:matthews

Conversation

@sanderland

@sanderland sanderland commented Nov 16, 2022

Copy link
Copy Markdown
Contributor

See #317

  • Refrained from adding 'micro' as an option for averaging, as I think it has too many pitfalls.
  • Would like to test a bit better, but not sure where to add this

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Nov 16, 2022

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@lvwerra
lvwerra self-requested a review November 16, 2022 10:12
@lvwerra

lvwerra commented Nov 16, 2022

Copy link
Copy Markdown
Member

Thanks for adding this! The tests for metrics are in the docstrings itself. So if you add an example or two to the docstring the will be tested by the CI. Also to fix the style tests you can run make style && make quality.

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@sanderland
sanderland marked this pull request as ready for review November 16, 2022 11:44
@sanderland

Copy link
Copy Markdown
Contributor Author

Should be all ready now @lvwerra

@lvwerra lvwerra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Would you mind also updating the README with the new options?

Comment thread metrics/matthews_correlation/matthews_correlation.py Outdated
Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@sanderland

Copy link
Copy Markdown
Contributor Author

@lvwerra gave it a shot, but there's not a lot of examples to go on as the multilabel config option is quite under-documented in general.

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@lvwerra

lvwerra commented Nov 17, 2022

Copy link
Copy Markdown
Member

Thank you for adding this!

@lvwerra
lvwerra merged commit 4ca8eed into huggingface:main Nov 17, 2022
@sanderland
sanderland deleted the matthews branch November 17, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants