Define supported redmine versions#361
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2.x #361 +/- ##
=========================================
Coverage 96.72% 96.72%
Complexity 534 534
=========================================
Files 27 27
Lines 1467 1467
=========================================
Hits 1419 1419
Misses 48 48 ☔ View full report in Codecov by Sentry. |
Art4
marked this pull request as draft
January 17, 2024 12:15
Art4
marked this pull request as ready for review
January 17, 2024 14:00
Co-authored-by: Kevin Saliou <kevin@saliou.name>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will define the supported Redmine versions in the
README.md.I've removed the manual installation instruction, because the service at php-download.com requires a login now. I've replaced this chapter completely with a sentence and a link to an alternative instruction. I hope that this isn't an issue anymore in 2024.
I've also updated the end2end tests. The logic from the testcase class has been moved to a PHPUnit extension to have more control over starting and resetting Redmine instances. It's not quite perfect and only works on Windows atm, but I will improve this over time.