Skip to content

Add Request interface and rename Response::getBody()#366

Merged
Art4 merged 6 commits into
v2.xfrom
363-rename-responsegetbody
Jan 30, 2024
Merged

Add Request interface and rename Response::getBody()#366
Art4 merged 6 commits into
v2.xfrom
363-rename-responsegetbody

Conversation

@Art4

@Art4 Art4 commented Jan 23, 2024

Copy link
Copy Markdown
Collaborator

This PR modifies the HttpClient::request() method to allow handling implementation of the new Request interface, described in #341. It also renames Response::getBody() to Response::getContent(), see #363.

In the tests I introduced an AssertingHttpClient that allows us easily define a HttpClient with asserted Requests and expected Responses. This will become very handy while starting deprecating the Redmine\Client\Client interface and replacing it in tests.

@Art4 Art4 added this to the v2.5.0 milestone Jan 23, 2024
@Art4 Art4 self-assigned this Jan 23, 2024
@Art4 Art4 linked an issue Jan 23, 2024 that may be closed by this pull request
@codecov

codecov Bot commented Jan 23, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c06b115) 96.84% compared to head (a9fb021) 96.80%.

Files Patch % Lines
src/Redmine/Api/AbstractApi.php 96.92% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               v2.x     #366      +/-   ##
============================================
- Coverage     96.84%   96.80%   -0.04%     
- Complexity      550      556       +6     
============================================
  Files            27       27              
  Lines          1523     1567      +44     
============================================
+ Hits           1475     1517      +42     
- Misses           48       50       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Art4
Art4 marked this pull request as ready for review January 23, 2024 13:50
@Art4
Art4 requested a review from kbsali January 23, 2024 13:51
@Art4
Art4 merged commit 2103392 into v2.x Jan 30, 2024
@Art4
Art4 deleted the 363-rename-responsegetbody branch January 30, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename Response::getBody() to Response::getContent()

1 participant