Skip to content

Let Clients implements HttpClient#370

Merged
Art4 merged 11 commits into
kbsali:v2.xfrom
Art4:implement-http-client-in-clients
Feb 1, 2024
Merged

Let Clients implements HttpClient#370
Art4 merged 11 commits into
kbsali:v2.xfrom
Art4:implement-http-client-in-clients

Conversation

@Art4

@Art4 Art4 commented Jan 31, 2024

Copy link
Copy Markdown
Collaborator

Refs #341.

@Art4 Art4 self-assigned this Jan 31, 2024
@Art4 Art4 added this to the v2.5.0 milestone Jan 31, 2024
@codecov

codecov Bot commented Jan 31, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4433cf0) 96.82% compared to head (ef1b7ce) 97.51%.
Report is 1 commits behind head on v2.x.

Files Patch % Lines
src/Redmine/Client/NativeCurlClient.php 90.90% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               v2.x     #370      +/-   ##
============================================
+ Coverage     96.82%   97.51%   +0.68%     
- Complexity      559      563       +4     
============================================
  Files            28       29       +1     
  Lines          1577     1607      +30     
============================================
+ Hits           1527     1567      +40     
+ Misses           50       40      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Art4
Art4 marked this pull request as ready for review January 31, 2024 15:31
@Art4
Art4 requested a review from kbsali January 31, 2024 15:32

@kbsali kbsali left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Art4 Art4 linked an issue Feb 1, 2024 that may be closed by this pull request
@Art4
Art4 merged commit ab5f4eb into kbsali:v2.x Feb 1, 2024
@Art4
Art4 deleted the implement-http-client-in-clients branch February 1, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify signature of the low-level API

2 participants