feat(editor): Added a new optional textDirection property to config t…#592
Merged
Conversation
…o set the 'dir' attribute on the editor div
kolkov
approved these changes
Jan 30, 2026
kolkov
left a comment
kolkov
left a comment
Owner
There was a problem hiding this comment.
LGTM! Clean implementation of RTL support.
Review:
- ✅ Proper TypeScript typing ()
- ✅ Uses standard HTML \ attribute
- ✅ Demo example included
- ✅ Minimal, focused change
Thanks @jamesey2001 for the contribution!
Closes #520
kolkov
approved these changes
Jan 30, 2026
kolkov
left a comment
kolkov
left a comment
Owner
There was a problem hiding this comment.
LGTM! Clean implementation of RTL support.
Review:
- Proper TypeScript typing
- Uses standard HTML dir attribute
- Demo example included
- Minimal, focused change
Thanks @jamesey2001 for the contribution!
Closes #520
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…o set the 'dir' attribute on the editor div
as per discussion here: #520
editor 1 in the demo application has the new attribute set to 'auto' so you can try it out.