feat: sonic convert and convert error handler#595
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands rerank conversion support for multimodal content, adds new rerank models, and standardizes several request-conversion errors into relay errors.
Changes:
- Adds Sonic AST-based rerank conversion/usage handling for Ali, OpenAI-compatible, and native video request paths.
- Adds convert-request error helpers across multiple adaptors and updates image/video/STT/chat/embedding conversion error paths.
- Adds tests for multimodal rerank conversion and relay-error behavior, and increases rerank timeout.
Reviewed changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| core/relay/plugin/timeout/timeout.go | Extends rerank request timeout. |
| core/relay/controller/rerank.go | Reworks rerank usage parsing with Sonic AST and multimodal text counting. |
| core/relay/controller/rerank_test.go | Adds rerank usage tests for string and multimodal requests. |
| core/relay/adaptor/text-embeddings-inference/rerank.go | Wraps rerank conversion validation errors as relay errors. |
| core/relay/adaptor/text-embeddings-inference/rerank_test.go | Verifies missing-documents error status. |
| core/relay/adaptor/siliconflow/video.go | Passes metadata through multipart image validation for relay errors. |
| core/relay/adaptor/siliconflow/error.go | Adds SiliconFlow convert-request error helper. |
| core/relay/adaptor/openai/video.go | Wraps multipart parse failures as relay errors. |
| core/relay/adaptor/openai/stt.go | Wraps STT multipart parse failures as relay errors. |
| core/relay/adaptor/openai/rerank.go | Adds multimodal rerank content normalization. |
| core/relay/adaptor/openai/rerank_test.go | Adds OpenAI-compatible rerank normalization tests. |
| core/relay/adaptor/openai/image.go | Wraps image request parse/validation errors as relay errors. |
| core/relay/adaptor/openai/error.go | Adds OpenAI convert-request error helper. |
| core/relay/adaptor/openai/embeddings.go | Wraps embedding JSON parse failures as relay errors. |
| core/relay/adaptor/openai/chat.go | Wraps chat conversion callback/stream-option errors as relay errors. |
| core/relay/adaptor/jina/constants.go | Registers the Jina multimodal reranker model. |
| core/relay/adaptor/gemini/video.go | Wraps Gemini video conversion validation errors as relay errors. |
| core/relay/adaptor/gemini/video_test.go | Adds Gemini video missing-prompt relay-error test. |
| core/relay/adaptor/gemini/image.go | Wraps Gemini image/edit validation errors as relay errors. |
| core/relay/adaptor/gemini/image_test.go | Adds Gemini image missing-prompt relay-error test. |
| core/relay/adaptor/gemini/error.go | Adds Gemini convert-request error helper. |
| core/relay/adaptor/doubao/video.go | Wraps Doubao video parse/validation failures as relay errors. |
| core/relay/adaptor/doubao/main_test.go | Adds Doubao video missing-content relay-error test. |
| core/relay/adaptor/doubao/error.go | Adds Doubao convert-request error helper. |
| core/relay/adaptor/doubao/doubao_video.go | Converts native Doubao video requests with Sonic AST. |
| core/relay/adaptor/ali/video.go | Wraps Ali video parse/validation failures as relay errors. |
| core/relay/adaptor/ali/rerank.go | Reworks Ali rerank conversion with Sonic AST and multimodal normalization. |
| core/relay/adaptor/ali/rerank_test.go | Adds Ali rerank Sonic/multimodal/image validation tests. |
| core/relay/adaptor/ali/image.go | Wraps Ali image/edit validation failures as relay errors. |
| core/relay/adaptor/ali/error.go | Adds Ali convert-request error helper. |
| core/relay/adaptor/ali/constants.go | Registers additional Ali rerank models. |
| core/relay/adaptor/ali/ali_video.go | Converts native Ali video requests with Sonic AST. |
| core/relay/adaptor/ali/adaptor_test.go | Adds Ali video invalid-variant relay-error test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return relaymodel.NewOpenAIError(http.StatusBadRequest, relaymodel.OpenAIError{ | ||
| Code: "InvalidParameter", | ||
| Message: "Image URL or Base64 is invalid. URL must be a valid HTTP/HTTPS link, " + | ||
| "and Base64 must start with 'image/xxx;base64' or be valid raw image base64", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.