fix(doubao): set reasoning_effort field in doubao reasoning conversion#616
Merged
Conversation
Previously, ApplyReasoningToDoubaoNode/Request only set the thinking field when applying reasoning config. Now they also set the reasoning_effort field mapped to doubao-specific values (minimal/low/medium/high), consistent with how other providers handle reasoning effort. Updated corresponding tests to verify reasoning_effort is correctly set.
|
|
Member
|
please fix the ci lint |
Contributor
Author
Fixed, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously,
ApplyReasoningToDoubaoNodeandApplyReasoningToDoubaoRequestonly set thethinkingfield when applying reasoning config. This PR adds thereasoning_effortfield, mapped to doubao-specific effort values (minimal/low/medium/high), consistent with how other providers handle reasoning effort.Changes
core/relay/utils/reasoning.go:ApplyReasoningToDoubaoNodenow setsreasoning_effortin addition tothinkingApplyReasoningToDoubaoRequestnow setsreasoning_effortin addition tothinkingdoubaoReasoningEffort()helper that maps normalized reasoning levels to doubao-specific effort valuescore/relay/adaptor/doubao/main_test.go:reasoning_effortis correctly setthinking.type enabled→thinking.type=enabled)