Add support for single precision (FP32) and mixed precision to KOKKOS…#4608
Merged
Conversation
Contributor
Author
|
A few more changes are coming to make "legacy" vs "kokkos" view types more explicit. |
This reverts commit eda6340.
Contributor
Author
|
Regression tests pass with double precision and both layouts. Most tests pass with single precision (a few are unstable but that is expected). @akohlmey this is ready to merge from my POV. |
Member
@stanmoore1 |
Contributor
Author
akohlmey
approved these changes
Aug 28, 2025
akohlmey
dismissed
alphataubio’s stale review
August 28, 2025 00:48
This review is outdated and the issues addressed where necessary
github-project-automation
Bot
moved this from In Progress
to Done
in LAMMPS Pull Requests
7 tasks
RichardZJM
added a commit
to RichardZJM/lammps-mtp-kokkos
that referenced
this pull request
Nov 21, 2025
Clarified version requirements for LAMMPS installation. A new release of LAMMPS (lammps/lammps#4608) has introduced support for FP32 and mixed precision, and requires minor modifications to this codebase to support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… package
Summary
Add support for single precision (FP32) and mixed precision to KOKKOS package
Related Issue(s)
Closes #4056.
Author(s)
Stan Moore (SNL). Helpful macros for view types in
KOKKOS/kokkos_type.hcontributed by Mitch Murphy (@alphataubio).Licensing
By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).
Backward Compatibility
Yes