add the MN15 D3(BJ) parameter to pair d3#4701
Merged
Merged
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn>
Member
This is a question for the contributors of this pair style: @soniasalomoni and @arthurfl |
megmcca
approved these changes
Aug 30, 2025
Collaborator
Actually we implemented only what was available here: https://www.chemie.uni-bonn.de/grimme/de/software/dft-d3/bj_damping , when I find some time I'll implement all the other parameterizations available in simple-dftd3. Otherwise, this looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the MN15 D3(BJ) parameter to
pair d3. Machine learning potential models trained against the MN15 functional have been used by LAMMPS in several publications (including mine) as follows, but the D3 correction has never been combined (while the dispersion is important). So it will be valuable to add the MN15 parameter.Related Issue(s)
Author(s)
Jinzhe Zeng (University of Science and Technology of China) jinzhe.zeng@ustc.edu.cn
Licensing
By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).
Backward Compatibility
N/A
Implementation Notes
The parameter is copied from https://github.com/dftd3/simple-dftd3/blob/442fbec1b0cf249359358ed247d90731d4da4b37/assets/parameters.toml#L422-L423.
What are the criteria for including parameters of functionals in LAMMPS? I am not sure why only a set of functionals are included.
Post Submission Checklist
Further Information, Files, and Links