Skip to content

Fix bug in KOKKOS Comm#4895

Merged
akohlmey merged 2 commits into
lammps:developfrom
stanmoore1:kk_bugfix
Feb 26, 2026
Merged

Fix bug in KOKKOS Comm#4895
akohlmey merged 2 commits into
lammps:developfrom
stanmoore1:kk_bugfix

Conversation

@stanmoore1

@stanmoore1 stanmoore1 commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fixes dangling pointer to host comm buffer which could lead to crashes when mixing KOKKOS and non-KOKKOS comm routines
  • Also fixes uninitialized variables which gave Valgrind warning

Related Issue(s)

None

Author(s)

Stan Moore (SNL)

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Artificial Intelligence (AI) Tools Usage

By submitting this pull request, I confirm that I did NOT use any AI tools to generate
all or parts of the code and modifications in this pull request.

Backward Compatibility

Yes

@athomps athomps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve.

@akohlmey
akohlmey merged commit f295976 into lammps:develop Feb 26, 2026
14 checks passed
@akohlmey

Copy link
Copy Markdown
Member

@stanmoore1 does this have to be added to the maintenance branch as well?

stanmoore1 added a commit that referenced this pull request Feb 26, 2026
@stanmoore1

Copy link
Copy Markdown
Contributor Author

@stanmoore1 does this have to be added to the maintenance branch as well?

Yes, done in e33eae6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants