[6.x] Fixes appendRow on console table

[crynobone]

There's some limitation with the new implementation.

• You can't call command with table from another command (the request to command will use BufferedOutput).
• You can't call command with table from a controller.

---

IMHO if developer want to use Table with appendRow() capability they should manually execute it inside Command instead of table() because the usage of ConsoleOutput on CLI usage while BufferedOutput when calling other commands or from a controller.

Signed-off-by: Mior Muhammad Zaki crynobone@gmail.com

[driesvints]

Does this fixes all the issues from #31445 ? (see comments after closing)

[crynobone]

Does this fixes all the issues from #31445 ?

It should because the current behaviour assume $this->output->getOutput() always have section() method but in reality only implementation of Symfony\Component\Console\Output\ConsoleOutput does while Laravel use Symfony\Component\Console\Output\BufferedOutput when using Illuminate\Foundation\Console\Kernel::call() instead of from artisan cli.

@driesvints I also include tests related to use of table() in command.

[crynobone]

But at the same time, checking the instanceof $output will give different output based how you execute the command so I would say it is better to let developer construct Table command directly if they want appendRow() feature instead of having it available via InteractsWithIO::table()

$output = $this->output->getOutput();

$table = new Table($output instanceof ConsoleOutput ? $output->section() : $output);

[taylorotwell]

@crynobone... sooo... do we want to merge this or not? You said it fixed the issue but then you seemed to imply the whole thing was a bad idea? I'm confused.

[crynobone]

@taylorotwell

You can only use $table->appendRow() when you run it directly from say php artisan command:name. If you do Artisan::call('command:name') it wouldn't work as described in testItCantExecuteCommandWithTableAndAppendRowDueToBufferedOutput().

This PR fixed:

• Running artisan command with table without mocking the output
• Running existing artisan command with table from Controller or another artisan command.
• Addes tests

[taylorotwell]

Reverting this entire feature and all related pieces of it @adam-prickett @crynobone ... it's causing continual problems.

[crynobone]

@taylorotwell I'm okay with that, but CommandWithTest and OuputStyle::getOutput() should be okay to stay in the core