unix,stream: don't clear writable flag on shutdown#2967
Closed
cjihrig wants to merge 1 commit into
Closed
Conversation
12be29f correctly updated uv_shutdown() to clear the writable flag on Unix platforms. However, the change is causing test failures in Node.js. This commit reverts the change so that the 1.39.0 release is unblocked.
vtjnash
approved these changes
Aug 24, 2020
Contributor
Author
|
Node+libuv integration CI: https://ci.nodejs.org/view/libuv/job/libuv-in-node/159/ |
Contributor
Author
|
None of the CI failures appear to be related, and macOS passed. |
bnoordhuis
approved these changes
Aug 24, 2020
bnoordhuis
left a comment
bnoordhuis
left a comment
Member
There was a problem hiding this comment.
LGTM with some trepidation. Per #2943 (comment), there's at least two ways to fix the regression, which suggests to me there could be more issues with 12be29f. I'd probably revert it wholesale.
Member
|
I agree with Ben here. I'd revert the whole commit and investigate what's going on. |
Contributor
Author
|
Closing this in favor of a full revert in #2968. |
JeffroMF
pushed a commit
to JeffroMF/libuv
that referenced
this pull request
May 16, 2022
This reverts commit 12be29f. The commit in question was introducing failures in the Node.js test suite. Refs: libuv#2943 Refs: libuv#2967 Refs: libuv#2409 PR-URL: libuv#2968 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
JeffroMF
pushed a commit
to JeffroMF/libuv
that referenced
this pull request
May 16, 2022
This reverts commit 46f36e3. PR-URL: libuv#3006 Refs: libuv#2967 Refs: libuv#2409 Refs: libuv#2943 Refs: libuv#2968 Refs: nodejs/node#36111 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Jul 23, 2025
This reverts commit 12be29f. The commit in question was introducing failures in the Node.js test suite. Refs: libuv/libuv#2943 Refs: libuv/libuv#2967 Refs: libuv/libuv#2409 PR-URL: libuv/libuv#2968 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Jul 23, 2025
This reverts commit 46f36e3. PR-URL: libuv/libuv#3006 Refs: libuv/libuv#2967 Refs: libuv/libuv#2409 Refs: libuv/libuv#2943 Refs: libuv/libuv#2968 Refs: nodejs/node#36111 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Dec 16, 2025
This reverts commit 12be29f. The commit in question was introducing failures in the Node.js test suite. Refs: libuv/libuv#2943 Refs: libuv/libuv#2967 Refs: libuv/libuv#2409 PR-URL: libuv/libuv#2968 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Dec 16, 2025
This reverts commit 46f36e3. PR-URL: libuv/libuv#3006 Refs: libuv/libuv#2967 Refs: libuv/libuv#2409 Refs: libuv/libuv#2943 Refs: libuv/libuv#2968 Refs: nodejs/node#36111 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
12be29f correctly updated uv_shutdown() to clear the writable
flag on Unix platforms. However, the change is causing test
failures in Node.js. This commit reverts the change so that the
1.39.0 release is unblocked.