BOLT 7: add reader requirement on canonical node id ordering.#1333
Merged
Conversation
We require this for writers, but omitted it for readers: ``` - MUST set `node_id_1` and `node_id_2` to the public keys of the two nodes operating the channel, such that `node_id_1` is the lexicographically-lesser of the two compressed keys sorted in ascending lexicographic order. ``` Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
sangbida
pushed a commit
to ElementsProject/lightning
that referenced
this pull request
Apr 24, 2026
…d node-ids. See lightning/bolts#1333 Every reader of the gossip_store gets upset, and we get many errors if this happens :( Reported-by: https://github.com/NishantBansal2003 Changelog-Fixed: Protocol: We correctly reject invalidly ordered channel_announcement messages. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
sangbida
pushed a commit
to sangbida/lightning
that referenced
this pull request
Apr 24, 2026
…d node-ids. See lightning/bolts#1333 Every reader of the gossip_store gets upset, and we get many errors if this happens :( Reported-by: https://github.com/NishantBansal2003 Changelog-Fixed: Protocol: We correctly reject invalidly ordered channel_announcement messages. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
t-bast
approved these changes
Apr 27, 2026
23 tasks
vincenzopalazzo
approved these changes
May 4, 2026
TheBlueMatt
added a commit
to TheBlueMatt/rust-lightning
that referenced
this pull request
May 11, 2026
We already enforced that nodes can't have a chanel with themselves, but the spec was updated to require strict ordering at lightning/bolts#1333 so we enforce this as well.
TheBlueMatt
added a commit
to TheBlueMatt/rust-lightning
that referenced
this pull request
May 12, 2026
We already enforced that nodes can't have a chanel with themselves, but the spec was updated to require strict ordering at lightning/bolts#1333 so we enforce this as well. Test fixes by claude.
TheBlueMatt
added a commit
to TheBlueMatt/rust-lightning
that referenced
this pull request
May 21, 2026
We already enforced that nodes can't have a chanel with themselves, but the spec was updated to require strict ordering at lightning/bolts#1333 so we enforce this as well. Test fixes by claude.
TheBlueMatt
added a commit
to TheBlueMatt/rust-lightning
that referenced
this pull request
May 21, 2026
We already enforced that nodes can't have a chanel with themselves, but the spec was updated to require strict ordering at lightning/bolts#1333 so we enforce this as well. Test fixes by claude.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We require this for writers, but omitted it for readers: