Skip to content

Reject empty operand in cd built-in#126

Merged
magicant merged 4 commits into
magicant:trunkfrom
c0d3-br3ak9r:cd-reject-empty-operand-104
Mar 12, 2025
Merged

Reject empty operand in cd built-in#126
magicant merged 4 commits into
magicant:trunkfrom
c0d3-br3ak9r:cd-reject-empty-operand-104

Conversation

@c0d3-br3ak9r

@c0d3-br3ak9r c0d3-br3ak9r commented Mar 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Made the following changes:

  • Update the implementation to add a check for an empty operand. The exit status should be 5 on error.
  • Update the test scripts.
  • Update the user manual.
  • Update the NEWS.

Fixes #104

magicant
magicant reviewed Mar 9, 2025
View reviewed changes

@magicant magicant left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread path.c Outdated
Comment thread path.c Outdated
c0d3-br3ak9r and others added 2 commits March 9, 2025 19:49
@c0d3-br3ak9r @magicant
Reject empty operand in cd built-in
5096d54 
Co-authored-by: WATANABE Yuki <magicant@wonderwand.net>
@c0d3-br3ak9r @magicant
Reject empty operand in cd built-in
4539898 
Co-authored-by: WATANABE Yuki <magicant@wonderwand.net>
@c0d3-br3ak9r

c0d3-br3ak9r commented Mar 9, 2025

Copy link
Copy Markdown
Contributor Author

Hi, I've resolved the comments. Let me know if you need anything more.

magicant
magicant reviewed Mar 10, 2025
View reviewed changes
Comment thread tests/cd-y.tst Outdated
@magicant magicant added this to the 2.59 milestone Mar 10, 2025
@c0d3-br3ak9r @magicant
Reject empty operand in cd built-in
5d4565b 
Co-authored-by: WATANABE Yuki <magicant@wonderwand.net>
magicant
magicant approved these changes Mar 10, 2025
View reviewed changes

@magicant magicant left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks!

@magicant
magicant merged commit 70b55ac into magicant:trunk Mar 12, 2025
magicant added a commit that referenced this pull request Mar 12, 2025
@magicant
Document cd built-in exit status with empty directory name
296ee46 
This commit updates the documentation to reflect the change in:
#126.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@magicant magicant magicant approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.59

Development

Successfully merging this pull request may close these issues.

Reject an empty operand in the cd built-in

2 participants

@c0d3-br3ak9r @magicant