Reject {n} redirection prefix#167
Merged
Merged
Conversation
This commit implements recognition of I/O location tokens that are always rejected as a syntax error. The shell may validly accept the I/O location syntax and semantics in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements recognition of I/O location tokens that are always rejected as a syntax error. The shell may validly accept the I/O location syntax and semantics in the future.
Summary by Copilot
This pull request introduces a new reserved syntax for file descriptors in braces before redirection operators, updates the parser to handle this syntax as a syntax error, and includes corresponding documentation and test updates. Below are the most important changes grouped by theme:
Syntax Reservation and Parsing Updates:
TT_IO_LOCATIONto the parser to represent the reserved{name}syntax before redirection operators. Updated thenext_tokenfunction to identify and classify this syntax asTT_IO_LOCATION. [1] [2]tryparse_redirectfunction to treatTT_IO_LOCATIONtokens as syntax errors, with appropriate error messages.TT_IO_LOCATIONtokens, ensuring they are rejected where appropriate. [1] [2]Documentation Updates:
doc/redir.txtanddoc/ja/redir.txtto document the reserved{name}syntax for future use, noting that it currently results in a syntax error. [1] [2]News and Release Notes:
NEWSandNEWS.jafiles to announce the reservation of the{name}syntax for file descriptors and its current treatment as a syntax error. [1] [2]Test Coverage:
tests/redir-y.tstto verify that{name}syntax is correctly identified as unsupported and results in syntax errors.